HIP/CUDA: set the paramerter value in maintain_cuda_graph instead of replaceing it. #12209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replaceing it. This avoids conflict with internal cuda/hip runtimes memory managment behavior.
github-actions
bot
added
Nvidia GPU
slaren
approved these changes
Mar 6, 2025
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
…replaceing it. (ggml-org#12209) This avoids conflict with internal cuda/hip runtimes memory managment behavior.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
…replaceing it. (ggml-org#12209) This avoids conflict with internal cuda/hip runtimes memory managment behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids conflict with internal cuda/hip runtime memory management behavior.
This fix is a stop gap fix for #12152